Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 添加redirect-url #4

Merged
merged 2 commits into from
Aug 27, 2023
Merged

feat: 添加redirect-url #4

merged 2 commits into from
Aug 27, 2023

Conversation

orangeboyChen
Copy link
Contributor

No description provided.

@orangeboyChen orangeboyChen requested a review from Saltro August 27, 2023 08:49
LSX-s-Software
LSX-s-Software requested changes Aug 27, 2023
View reviewed changes
Copy link
Member

@LSX-s-Software LSX-s-Software left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'isSuccess' is always truthy, use 'isSuccess.value' instead.

Saltro
Saltro reviewed Aug 27, 2023
View reviewed changes
pages/certify-success.vue Outdated Show resolved Hide resolved
pages/login.vue Outdated Show resolved Hide resolved
@orangeboyChen orangeboyChen force-pushed the feature/redirect_url branch 3 times, most recently from 3f95243 to 4634e41 Compare August 27, 2023 10:10
Saltro
Saltro reviewed Aug 27, 2023
View reviewed changes
utils/callback.ts Outdated Show resolved Hide resolved
@orangeboyChen orangeboyChen merged commit 49af1cb into master Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saltro Saltro Saltro left review comments

@LSX-s-Software LSX-s-Software LSX-s-Software requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orangeboyChen @LSX-s-Software @Saltro