Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] add type adaptation feature in Humble. #14

Closed
ZhenshengLee opened this issue Jun 23, 2022 · 3 comments
Closed

[FEA] add type adaptation feature in Humble. #14

ZhenshengLee opened this issue Jun 23, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ZhenshengLee
Copy link
Owner

https://github.com/ros-infrastructure/rep/blob/master/rep-2007.rst

@ZhenshengLee ZhenshengLee self-assigned this Jul 15, 2022
@ZhenshengLee ZhenshengLee added the enhancement New feature or request label Jul 15, 2022
@ZhenshengLee ZhenshengLee added this to the PR1 milestone Sep 27, 2022
@ZhenshengLee
Copy link
Owner Author

ZhenshengLee commented Sep 29, 2022

see
ros2/demos#482
ros2/demos#583

ros-perception/vision_opencv#441

I don't see the priority, cause it doesn't improve the performance.

@ZhenshengLee
Copy link
Owner Author

But in rclcpp-intra-process, type conversion is avoided, see following

ros2/rclcpp#1849
ros2/ros2_documentation#2377
ros2/rclcpp#1664

this make it possible to improve cuda performance, because cudamemcpy canbe avoided too!

see this example of intra-process-cuda-image-pipeline https://github.com/NVIDIA-ISAAC-ROS/ros2_examples/tree/humble/rclcpp/type_adaptation/accelerated_pipeline

Anyway , rclcpp-intra-process is not for ros2_shm_msgs.

@ZhenshengLee
Copy link
Owner Author

zero-copy can be achieved with intra-process since dashing(stable in foxy), the type-adaption feature is mostly for saving costs in the GPU processing of image/pointclouds. this issue will be merged into #18

closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant