Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Snackbar): add progress bar on Snackbar #292

Merged
merged 18 commits into from
Apr 15, 2024

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Apr 10, 2024

Progress bar is enabled by default on snackbars configured to hide after a timeout

Refs: CDS-212 CDS-71

@beawar beawar self-assigned this Apr 10, 2024
@beawar beawar requested review from a team as code owners April 10, 2024 13:35
@beawar beawar marked this pull request as draft April 10, 2024 13:36
@beawar beawar marked this pull request as ready for review April 11, 2024 06:58
@beawar
Copy link
Contributor Author

beawar commented Apr 11, 2024

Base automatically changed from CDS-211-fix-snackbar-component-on-ds to devel April 12, 2024 14:06
@beawar beawar dismissed CataldoMazzilli’s stale review April 12, 2024 14:06

The base branch was changed.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 96.20% Coverage (82.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.10% Estimated after merge)

Project ID: carbonio-design-system

View in SonarQube

@CataldoMazzilli CataldoMazzilli self-requested a review April 12, 2024 15:11
@beawar beawar merged commit 3a7ded1 into devel Apr 15, 2024
3 checks passed
@beawar beawar deleted the CDS-212-snackbar-add-progress-bar branch April 15, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants