Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cds 216 align ds #280

Merged
merged 23 commits into from
Mar 28, 2024
Merged

Cds 216 align ds #280

merged 23 commits into from
Mar 28, 2024

Conversation

rodleyorosa
Copy link
Contributor

@rodleyorosa rodleyorosa commented Mar 25, 2024 •
edited
Loading

No description provided.

@rodleyorosa rodleyorosa self-assigned this Mar 25, 2024
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@rodleyorosa rodleyorosa changed the base branch from devel to CDS-214-Move-to-Storybook March 25, 2024 08:51
@rodleyorosa
feat: deprecate status prop
bf8dbd4 
the status prop is now deprecated, use the severity one instead

Refs:CDS-216
rodleyorosa and others added 16 commits March 25, 2024 11:42
@rodleyorosa
refactor: remove unnecessary addons
fec0d2c 
Refs: CDS-214
@rodleyorosa
feat: add dark mode
f44789f 
Refs: CDS-214
@rodleyorosa
Merge branch 'devel' into CDS-214-Move-to-Storybook
dfff396
@rodleyorosa
fix: apply review hints
4c67b80 
Refs: CDS-214
@rodleyorosa
Merge remote-tracking branch 'origin/devel' into CDS-214-Move-to-Stor…
1a8c965 
…ybook
@rodleyorosa
Merge branch 'CDS-214-Move-to-Storybook' of github.com:zextras/carbon…
c7f509a 
…io-design-system into CDS-214-Move-to-Storybook
@rodleyorosa
Merge remote-tracking branch 'origin/CDS-214-Move-to-Storybook' into …
91474be 
…CDS-216-Align-DS
@rodleyorosa
ci: add deploy doc step for validation
6fbdba8 
Refs: CDS-214
@rodleyorosa
Merge branch 'CDS-214-Move-to-Storybook' into CDS-216-Align-DS
6bf5ae5
@rodleyorosa
ci: update expression into build doc
b9e9e7e 
Refs: CDS-214
@rodleyorosa
Merge branch 'CDS-214-Move-to-Storybook' into CDS-216-Align-DS
70bfe36
@rodleyorosa
ci: add no-extraneous-dep for stories files
722fdfb 
Refs: CDS-214
@rodleyorosa
fix: apply review hints
ac05b6c 
Refs: CDS-214
@rodleyorosa
refactor: remove autodocs from configs
45d7d78 
Refs: CDS-214
@rodleyorosa
Merge branch 'CDS-214-Move-to-Storybook' into CDS-216-Align-DS
7ea5ab9
@rodleyorosa
docs: update banner docs
2504fe7 
Refs: CDS-216
Base automatically changed from CDS-214-Move-to-Storybook to devel March 28, 2024 08:00
@rodleyorosa rodleyorosa marked this pull request as ready for review March 28, 2024 08:09
@rodleyorosa rodleyorosa requested a review from a team as a code owner March 28, 2024 08:09
@rodleyorosa rodleyorosa requested review from a team as code owners March 28, 2024 08:09
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
beawar
beawar previously approved these changes Mar 28, 2024
View reviewed changes
src/components/feedback/banner/Banner.mdx Show resolved Hide resolved
@rodleyorosa
docs: update doc
c7092e9 
Refs: CDS-216
@rodleyorosa rodleyorosa dismissed stale reviews from CataldoMazzilli and beawar via c7092e9 March 28, 2024 10:22
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (81.90% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.10% Estimated after merge)

Project ID: carbonio-design-system

View in SonarQube

@rodleyorosa rodleyorosa merged commit 0d24a14 into devel Mar 28, 2024
3 checks passed
@rodleyorosa rodleyorosa deleted the CDS-216-Align-DS branch March 28, 2024 16:41
beawar added a commit that referenced this pull request Apr 9, 2024
@beawar
feat(Banner): align component to UI kit
9122422 
Add severity prop and deprecate status prop

This is an empty commit to track the changes made in 0d24a14

Refs: CDS-213 CDS-216 0d24a14 (#280)
beawar added a commit that referenced this pull request Apr 9, 2024
@beawar
feat(Banner): align component to UI kit
8e8f504 
Add severity prop and deprecate status prop

This is an almost empty commit to track the changes made in 0d24a14

Refs: CDS-213 CDS-216 0d24a14 (#280)
beawar added a commit that referenced this pull request Apr 9, 2024
@beawar
feat(Banner): align component to UI kit
287c33f 
Add severity prop and deprecate status prop

This is an almost empty commit to track the changes made in 0d24a14

Refs: CDS-213 CDS-216 0d24a14 (#280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CataldoMazzilli CataldoMazzilli CataldoMazzilli approved these changes

@beawar beawar beawar approved these changes

Assignees

@rodleyorosa rodleyorosa

Labels
validated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodleyorosa @beawar @CataldoMazzilli @eugeniamuff