fix(Dropdown): allow keyboard navigation on nested dropdowns #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor nested dropdown to have the same keyboard shortcut of the main list Allow the opening of the nested dropdown with ArrowRight Allow the closing of the nested dropdown with ArrowLeft and Escape Set focus on nested dropdown trigger when closing the nested dropdown Manage the opening and closing of the nested dropdown with an internal listener instead of an external state Remove timeouts where possible refs: CDS-182 CDS-138 CDS-70
Set tabindex to -1 to allow to external container to get focus programmatically only. When grid get focused, set the focus to the primary button.
…items-at-the-top-and-end-of-the-list-and-update-the-logic-of-the-keyboard-navigation-to-consider-the-first-and-last-elements-as-start-and-end-sentinels-for-the-keyboard-navigation
gnekoz
previously approved these changes
Sep 13, 2023
lisaparma
previously approved these changes
Sep 14, 2023
…entinel-elements-white-items-at-the-top-and-end-of-the-list-and-update-the-logic-of-the-keyboard-navigation-to-consider-the-first-and-last-elements-as-start-and-end-sentinels-for-the-keyboard-navigation
CataldoMazzilli
dismissed stale reviews from lisaparma and gnekoz
via
7eca36e
CataldoMazzilli
approved these changes
Sep 20, 2023
lisaparma
approved these changes
Sep 20, 2023
CataldoMazzilli
deleted the
CDS-183-Remove-the-sentinel-elements-white-items-at-the-top-and-end-of-the-list-and-update-the-logic-of-the-keyboard-navigation-to-consider-the-first-and-last-elements-as-start-and-end-sentinels-for-the-keyboard-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: separate functions in useKeyboard
test: reorganize test utils and export extended screen and within
test: add test for keyboard usage of Dropdown
fix(Dropdown): allow keyboard navigation on nested dropdowns
Refactor nested dropdown to have the same keyboard shortcut of the main list
Allow the opening of the nested dropdown with ArrowRight
Allow the closing of the nested dropdown with ArrowLeft and Escape
Set focus on nested dropdown trigger when closing the nested dropdown
Manage the opening and closing of the nested dropdown with an internal listener
instead of an external state
Remove timeouts where possible
fix(Button): set focus on primary button when grid is focused
docs(Dropdown): add keyboard shortcut section
refs: CDS-182 CDS-138 CDS-70