-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Radio): improve Radio component #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CerDennis
previously approved these changes
Jul 14, 2023
refs: CDS-166
beawar
changed the title
refactor(Radio): use input and label elements instead of divs
feat(Radio): improve Radio component
Jul 14, 2023
CerDennis
previously approved these changes
Jul 14, 2023
nubsthead
reviewed
Jul 17, 2023
CataldoMazzilli
previously approved these changes
Jul 17, 2023
nubsthead
previously approved these changes
Jul 18, 2023
CataldoMazzilli
approved these changes
Jul 18, 2023
CerDennis
approved these changes
Jul 18, 2023
nubsthead
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace divs with input and label to make rendered element more accessible and testable.
Make type of value generic, so that it can be reduced to a subset of type string.
refs: CDS-166 CDS-57