Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Radio): improve Radio component #199

Merged
merged 4 commits into from
Jul 18, 2023
Merged

feat(Radio): improve Radio component #199

merged 4 commits into from
Jul 18, 2023

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Jul 14, 2023

Replace divs with input and label to make rendered element more accessible and testable.
Make type of value generic, so that it can be reduced to a subset of type string.

refs: CDS-166 CDS-57

CerDennis
CerDennis previously approved these changes Jul 14, 2023
@beawar beawar changed the title refactor(Radio): use input and label elements instead of divs feat(Radio): improve Radio component Jul 14, 2023
@beawar beawar requested a review from CerDennis July 14, 2023 14:03
CerDennis
CerDennis previously approved these changes Jul 14, 2023
src/components/inputs/Radio.tsx Outdated Show resolved Hide resolved
src/components/inputs/Radio.tsx Show resolved Hide resolved
@beawar beawar requested a review from CerDennis July 17, 2023 16:00
@beawar beawar self-assigned this Jul 17, 2023
nubsthead
nubsthead previously approved these changes Jul 18, 2023
src/components/inputs/Radio.tsx Outdated Show resolved Hide resolved
@beawar beawar merged commit 3b21c71 into devel Jul 18, 2023
@beawar beawar deleted the CDS-166-improve-radio branch July 18, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants