Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextArea): create TextArea component #174

Merged
merged 1 commit into from
Feb 28, 2023
Merged

feat(TextArea): create TextArea component #174

merged 1 commit into from
Feb 28, 2023

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Feb 23, 2023

Create TextArea component, add tests and documentation.

refactor: extract common internal components for input-like components.

Replace replicas of these common components in Input and ChipInput.

fix(Divider): update Divider to set color for background instead of border

Setting border was creating an empty space above the border when page has a big zoom. By removing the border and setting the color in the background, this empty space is removed.

docs: update styleguide config to exclude subdirectories for inputs folder

refs: CDS-124

Create TextArea component, add tests and documentation.

refactor: extract common internal components for input-like components.

Replace replicas of these common components in Input and ChipInput.

fix(Divider): update Divider to set color for background instead of border

Setting border was creating an empty space above the border when page has
a big zoom. By removing the border and setting the color in the background,
this empty space is removed.

docs: update styleguide config to exclude subdirectories for inputs folder

refs: CDS-124
@beawar beawar self-assigned this Feb 23, 2023
@beawar beawar requested review from a team as code owners February 23, 2023 11:56
@beawar beawar merged commit 1215455 into devel Feb 28, 2023
@beawar beawar deleted the CDS-124-textarea branch February 28, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants