Cds 73 whitelabeling migrate icons to ts #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beawar
requested review from
nubsthead,
giuliano176,
geeky-abhishek,
dhavaldodiya,
CataldoMazzilli,
lisaparma,
CerDennis,
gnekoz and
Gammax92
as code owners
CataldoMazzilli
previously approved these changes
Oct 25, 2022
CataldoMazzilli
previously approved these changes
Nov 4, 2022
…-migrate-icons-to-ts
refs: CDS-95 (#139)
gnekoz
approved these changes
Nov 10, 2022
CataldoMazzilli
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of files inside the pr BUT most of them are icons migrated from js to ts.
I suggest splitting the review per single commit.
I could not split these three commits because they are all required to use the theme correctly from outside with the icons now typed as well.