fix: clear popper listener register on unmount

refs: (#95)
zextras · Jul 25, 2022 · 7c8facd · 7c8facd
1 parent fe07401
commit 7c8facd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/components/display/Popover.tsx b/src/components/display/Popover.tsx
@@ -81,7 +81,9 @@ const Popover = React.forwardRef<HTMLDivElement, PopoverProps>(function PopoverF
 		}
 	}, [onMouseMove, anchorEl]);
 
-	const innerOnClose = useCallback(() => !activateOnHover && onClose(), [activateOnHover, onClose]);
+	const innerOnClose = useCallback(() => {
+		!activateOnHover && onClose();
+	}, [activateOnHover, onClose]);
 
 	const onMouseEnter = useCallback(
 		() =>

diff --git a/src/components/display/Popper.tsx b/src/components/display/Popper.tsx
@@ -173,15 +173,17 @@ const Popper = React.forwardRef<HTMLDivElement, PopperProps>(function PopperFn(
 	}, [open, placement, anchorEl, virtualElement, popperRef]);
 
 	useEffect(() => {
+		let listenerTimeout: ReturnType<typeof setTimeout>;
 		if (open) {
-			setTimeout(() => {
+			listenerTimeout = setTimeout(() => {
 				windowObj.document.addEventListener('click', closePopper);
 			}, 1);
 		}
 		return (): void => {
 			windowObj.document.removeEventListener('click', closePopper);
+			listenerTimeout && clearTimeout(listenerTimeout);
 		};
-	}, [open, closePopper, windowObj.document]);
+	}, [open, closePopper, windowObj]);
 
 	useEffect(() => {
 		const startSentinelRefSave = startSentinelRef.current;