Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical junk commanders cause luarules errors #5433

Open
GoogleFrog opened this issue Jan 5, 2025 · 1 comment
Open

Technical junk commanders cause luarules errors #5433

GoogleFrog opened this issue Jan 5, 2025 · 1 comment

Comments

@GoogleFrog
Copy link
Contributor

image

A bunch of stuff crashes because a spawned clonedef commander (dyncommbla5_1001 etc) has the custom params of a commander, but lacks the unit rules params it would get from being created by the dynamic commander gadget. They don't even know which weapons they are supposed to be able to fire.

Someone made a bug report with such a commander, so they should be removed from the technical junk menu. Their creation could also be disallowed via AllowUnitCreation in the dynamic commander gadget.

@sprunk
Copy link
Member

sprunk commented Jan 5, 2025

If disallowing them via AllowUnitCreation don't forget to let rez and zombies through. Perhaps the dynamic comm gadget needs to handle those cases anyway due to #5140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants