Skip to content

Commit

Permalink
chore: Removing unused styles, extra space in entity item and passing…
Browse files Browse the repository at this point in the history
… button condition prop (appsmithorg#37674)

## Description

- Removing unused styles and extra space between icon and entity name in
entity item component
- Passing button condition prop that is missing to show the warning icon
on Data tab in sidebar, when there are no datasources connected in the
workspace

Fixes [appsmithorg#37675](appsmithorg#37675)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12009273207>
> Commit: f4bc4ab
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12009273207&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 25 Nov 2024 12:15:09 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a `condition` property for enhanced button configuration in
the sidebar.
- Added an optional `preRightIcon` property to the `Entity` component
for improved icon customization.

- **Bug Fixes**
- Simplified styling of the `IconWrapper`, potentially improving icon
display.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
ankitakinger authored Nov 25, 2024
1 parent c7c01a6 commit 88b9fea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
2 changes: 2 additions & 0 deletions src/IDE/Components/Sidebar/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ function IDESidebar(props: IDESidebarProps) {
<div>
{topButtons.map((button) => (
<SidebarButton
condition={button.condition}
icon={button.icon}
key={button.state}
onClick={onClick}
Expand All @@ -52,6 +53,7 @@ function IDESidebar(props: IDESidebarProps) {
<div>
{bottomButtons.map((button) => (
<SidebarButton
condition={button.condition}
icon={button.icon}
key={button.state}
onClick={onClick}
Expand Down
10 changes: 0 additions & 10 deletions src/pages/Editor/Explorer/Entity/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -203,20 +203,10 @@ export const EntityItem = styled.div<{
`;

const IconWrapper = styled.span`
line-height: ${(props) => props.theme.lineHeights[0]}px;
color: var(--ads-v2-color-fg);
display: flex;
align-items: center;
div {
cursor: pointer;
}
svg {
width: 16px;
height: 16px;
}
margin-right: 4px;
`;

export const AddButtonWrapper = styled.div`
Expand Down

0 comments on commit 88b9fea

Please sign in to comment.