Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually implement serde::Serialize/Deserialize for bigger t values #3

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Nov 4, 2021

We might want t that is bigger than 32, which will then break auto deriving serialize/deserialize because of serde-rs/serde#631.
I wanted to implement this myself, but the implementation gets very big and complex very fast (you need multiple types, and visitors, implementing traits for all of them etc.), instead I found that a common crate that allows you to do it: jonasbb/serde_with#272

@omershlo
Copy link
Contributor

omershlo commented Nov 4, 2021

brilliant,
mandatory question: have you run the test with c=2 t=76?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants