Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore possibility to be database agnostic #8

Open
Zegnat opened this issue May 10, 2018 · 2 comments
Open

Explore possibility to be database agnostic #8

Zegnat opened this issue May 10, 2018 · 2 comments
Labels

Comments

@Zegnat
Copy link
Owner

Zegnat commented May 10, 2018

While there are a few reasons for why I used an SQLite database as the storage behind Mintoken, it may be possible to let the user setup any PDO connection they want. That way any storage compatible with PDO will be compatible with Mintoken.

A few things to note:

  1. This means the SQLs need to be as globally supported as possible. Is there some standard SQL dialect that should be aimed for?
  2. Are there possible security mismatches between different databases?

As far as 2 goes, look into what the security experts from Paragon are doing in EasyDB.

@Zegnat Zegnat added the idea label May 10, 2018
@Zegnat
Copy link
Owner Author

Zegnat commented May 11, 2018

My SQLs are probably simple enough to just use ANSI SQL. Maybe even SQL 92?

This could come in paired with following a style guide.

@Zegnat
Copy link
Owner Author

Zegnat commented May 13, 2018

As of The Thoughtful Edition, all SQL should be SQL-92. And the style guide has been loosely applied.

Next up would be switching to a dynamic DSN setting, instead of the SQLite path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant