Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine oldest Firefox version compatibility #5

Closed
grahamperrin opened this issue Sep 4, 2019 · 6 comments
Closed

Determine oldest Firefox version compatibility #5

grahamperrin opened this issue Sep 4, 2019 · 6 comments
Assignees
Labels
AMO Firefox Add-ons platform, addons.mozilla.org chore
Milestone

Comments

@grahamperrin
Copy link

When I first tested with recent Waterfox Classic 56.2.13, menu options were apparent. From a screen recording:

vlcsnap-2019-09-04-03h25m48s652

– however the windows did not merge.

The browser crashed (maybe because I was thrashing the OS, FreeBSD-CURRENT, at the time, with software builds).

After relaunching the app: menu options are no longer apparent:

image

Can you add compatibility with Waterfox Classic? (Historically: Waterfox 56.0 was based on Firefox 56.0.2.)

Or does the extension need a strict_min_version?

@Zegnat Zegnat changed the title Compatibility Determine oldest Firefox version compatibility Sep 4, 2019
@Zegnat Zegnat self-assigned this Sep 4, 2019
@Zegnat Zegnat added this to the v1.0.0 milestone Sep 4, 2019
@Zegnat Zegnat added AMO Firefox Add-ons platform, addons.mozilla.org chore labels Sep 4, 2019
@Zegnat
Copy link
Owner

Zegnat commented Sep 4, 2019

I will go and figure out what the oldest version of Firefox is that can be supported by my code-base. This may end up including Firefox 56. If it is Waterfox that breaks the browser extension API, I can already say I will not be fixing that as I am not a Waterfox user.

I could be persuaded to accept PRs to lower the version requirements, or fix Waterfox. But I’ll leave that to separate issues when it comes up.

Definitely should add clear compatibility notes before the v1.0.0 release!

@Zegnat
Copy link
Owner

Zegnat commented Sep 4, 2019

Upon first check: this extension does not support anything before Fx 62 because of its use of flatMap (see browser compatibility). This is why Waterfox 56.2.13 doesn’t seem to be able to run the action from the context menu.

@Zegnat
Copy link
Owner

Zegnat commented Sep 4, 2019

Pushed a release limiting to Fx 62 for now, so I will not be giving people any false hopes while I look for a good minimum version to support.

My first feeling is to support down to the latest ESR release. This is currently 60.9.0. If Waterfox is API compatible with that release, all should be fine. I may not get to test with ESR ’til the upcoming weekend, which is one of the reasons for pushing a more limiting release first.

Thanks for you vigilance!

@Zegnat
Copy link
Owner

Zegnat commented Sep 4, 2019

Closing this in favour of #6 and #7 to separately track older Firefox support and possible Waterfox support.

@Zegnat Zegnat closed this as completed Sep 4, 2019
@Zegnat
Copy link
Owner

Zegnat commented Sep 8, 2019

@grahamperrin just a friendly ping that, as of the v0.4.0 release Window Merger should be available on Waterfox 🎊

@grahamperrin
Copy link
Author

@Zegnat belated thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMO Firefox Add-ons platform, addons.mozilla.org chore
Projects
None yet
Development

No branches or pull requests

2 participants