-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine oldest Firefox version compatibility #5
Comments
I will go and figure out what the oldest version of Firefox is that can be supported by my code-base. This may end up including Firefox 56. If it is Waterfox that breaks the browser extension API, I can already say I will not be fixing that as I am not a Waterfox user. I could be persuaded to accept PRs to lower the version requirements, or fix Waterfox. But I’ll leave that to separate issues when it comes up. Definitely should add clear compatibility notes before the v1.0.0 release! |
Upon first check: this extension does not support anything before Fx 62 because of its use of flatMap (see browser compatibility). This is why Waterfox 56.2.13 doesn’t seem to be able to run the action from the context menu. |
Pushed a release limiting to Fx 62 for now, so I will not be giving people any false hopes while I look for a good minimum version to support. My first feeling is to support down to the latest ESR release. This is currently 60.9.0. If Waterfox is API compatible with that release, all should be fine. I may not get to test with ESR ’til the upcoming weekend, which is one of the reasons for pushing a more limiting release first. Thanks for you vigilance! |
@grahamperrin just a friendly ping that, as of the v0.4.0 release Window Merger should be available on Waterfox 🎊 |
@Zegnat belated thanks! |
When I first tested with recent Waterfox Classic 56.2.13, menu options were apparent. From a screen recording:
– however the windows did not merge.
The browser crashed (maybe because I was thrashing the OS, FreeBSD-CURRENT, at the time, with software builds).
After relaunching the app: menu options are no longer apparent:
Can you add compatibility with Waterfox Classic? (Historically: Waterfox 56.0 was based on Firefox 56.0.2.)
Or does the extension need a
strict_min_version
?The text was updated successfully, but these errors were encountered: