From 09e7c117e65cf554b1c79f1acb9bfb144a61ab25 Mon Sep 17 00:00:00 2001 From: Gustavo Valverde Date: Mon, 19 Dec 2022 10:06:43 -0400 Subject: [PATCH 1/4] fix(ci): remove warnings caused by missing `actions/checkout` --- .github/workflows/continous-delivery.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/continous-delivery.yml b/.github/workflows/continous-delivery.yml index 04828142ed9..1b063f1f741 100644 --- a/.github/workflows/continous-delivery.yml +++ b/.github/workflows/continous-delivery.yml @@ -99,6 +99,10 @@ jobs: if: ${{ !cancelled() && !failure() && ((github.event_name == 'push' && github.ref_name == 'main') || github.event_name == 'release') }} steps: + - uses: actions/checkout@v3.2.0 + with: + persist-credentials: false + - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 with: @@ -189,6 +193,10 @@ jobs: if: github.event_name == 'workflow_dispatch' steps: + - uses: actions/checkout@v3.2.0 + with: + persist-credentials: false + - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 with: From 9619258ded67a95000717d4fd032f68d5d489cc5 Mon Sep 17 00:00:00 2001 From: Gustavo Valverde Date: Mon, 9 Jan 2023 10:48:52 -0400 Subject: [PATCH 2/4] fix: typo in arguments --- .github/workflows/continous-delivery.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/continous-delivery.yml b/.github/workflows/continous-delivery.yml index 1b063f1f741..e5ae282fcf3 100644 --- a/.github/workflows/continous-delivery.yml +++ b/.github/workflows/continous-delivery.yml @@ -225,7 +225,7 @@ jobs: --container-stdin \ --container-tty \ --container-image ${{ env.GAR_BASE }}/zebrad@${{ needs.build.outputs.image_digest }} \ - --create-disk=name=auto-delete=yes,size=300GB,type=pd-ssd \ + --create-disk=auto-delete=yes,size=300GB,type=pd-ssd \ --container-mount-disk=mount-path='/zebrad-cache' \ --machine-type ${{ env.MACHINE_TYPE }} \ --zone ${{ env.ZONE }} \ From c4ae96724695ca28dee01ec52149c08dc43b0ea2 Mon Sep 17 00:00:00 2001 From: Gustavo Valverde Date: Mon, 9 Jan 2023 16:06:16 -0400 Subject: [PATCH 3/4] fix: add the whole disk name as this is a single instance --- .github/workflows/continous-delivery.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/continous-delivery.yml b/.github/workflows/continous-delivery.yml index e5ae282fcf3..8a680c9752d 100644 --- a/.github/workflows/continous-delivery.yml +++ b/.github/workflows/continous-delivery.yml @@ -226,6 +226,7 @@ jobs: --container-tty \ --container-image ${{ env.GAR_BASE }}/zebrad@${{ needs.build.outputs.image_digest }} \ --create-disk=auto-delete=yes,size=300GB,type=pd-ssd \ + --create-disk=name=zebrad-cache-${{ env.GITHUB_SHA_SHORT }},auto-delete=yes,size=300GB,type=pd-ssd \ --container-mount-disk=mount-path='/zebrad-cache' \ --machine-type ${{ env.MACHINE_TYPE }} \ --zone ${{ env.ZONE }} \ From 40007ff8bff502bfd41aa619da172ed5da2ad21b Mon Sep 17 00:00:00 2001 From: Gustavo Valverde Date: Mon, 9 Jan 2023 16:07:30 -0400 Subject: [PATCH 4/4] fix: add dis name to mount --- .github/workflows/continous-delivery.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/continous-delivery.yml b/.github/workflows/continous-delivery.yml index 8a680c9752d..1adb5297d70 100644 --- a/.github/workflows/continous-delivery.yml +++ b/.github/workflows/continous-delivery.yml @@ -227,7 +227,7 @@ jobs: --container-image ${{ env.GAR_BASE }}/zebrad@${{ needs.build.outputs.image_digest }} \ --create-disk=auto-delete=yes,size=300GB,type=pd-ssd \ --create-disk=name=zebrad-cache-${{ env.GITHUB_SHA_SHORT }},auto-delete=yes,size=300GB,type=pd-ssd \ - --container-mount-disk=mount-path='/zebrad-cache' \ + --container-mount-disk=mount-path='/zebrad-cache',name=zebrad-cache-${{ env.GITHUB_SHA_SHORT }} \ --machine-type ${{ env.MACHINE_TYPE }} \ --zone ${{ env.ZONE }} \ --labels=app=zebrad,environment=qa,network=${NETWORK},github_ref=${{ env.GITHUB_REF_SLUG_URL }} \