-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev): Make zcash-rpc-diff always check Zebra then zcashd #5822
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5822 +/- ##
==========================================
+ Coverage 78.69% 78.73% +0.04%
==========================================
Files 308 308
Lines 38781 38781
==========================================
+ Hits 30517 30535 +18
+ Misses 8264 8246 -18 |
@Mergifyio update |
✅ Branch has been successfully updated |
There shouldn't be any Rust code in this PR, I'll fix it. |
35b48f3
to
ef7aa5a
Compare
It should be fixed now, I probably caused this by basing my branch off the RPC I was testing. |
Motivation
Sometimes they were in the opposite order in the script, which is confusing when reviewing diffs.
Review
This is a minor usability fix for a developer testing tool.
I used it for the 3 diffs in:
#5808 (comment)
Reviewer Checklist