From 12f06b848b81ed9a425f8e9be496bd32c092da84 Mon Sep 17 00:00:00 2001 From: Marek Date: Tue, 19 Oct 2021 14:57:16 +0200 Subject: [PATCH 1/3] Specify the location of the user agent string --- .github/PULL_REQUEST_TEMPLATE/release-checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md index 74f94a07f4f..b8df3f72429 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md +++ b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md @@ -16,6 +16,7 @@ To check if any of the top-level crates need version increments, go to the zebra - [ ] Increment the crates that have new commits since the last version update - [ ] Increment any crates that depend on crates that have changed - [ ] Use the `zebrad` crate version in the `zebra-network` user agent string + (currently the constant `USER_AGENT` in `zebra-network/src/constants.rs`) - [ ] Use the latest git tag in `README.md` ### How to Increment Versions From ce919e475701d0115815dc340c3cf03a3272f55e Mon Sep 17 00:00:00 2001 From: Marek Date: Tue, 19 Oct 2021 15:55:50 +0200 Subject: [PATCH 2/3] Specify the `cargo install` command --- .github/PULL_REQUEST_TEMPLATE/release-checklist.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md index b8df3f72429..84a15a9fac0 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md +++ b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md @@ -90,7 +90,8 @@ Also check for crates that depend on crates that have changed. They should get a ## Initial Testing -- [ ] After any changes, test that the `cargo install` command in `README.md` works (use `--path` instead of `--git` locally) +- [ ] After any changes, test that the `cargo install` command in works. Use + e.g. `cargo install --locked --path zebrad`. ## Change Log @@ -130,8 +131,8 @@ From "Keep a Changelog": ## Final Testing -- [ ] After tagging the release, test that the exact `cargo install` command works - (`--git` behaves a bit differently to `--path`) +- [ ] After tagging the release, test that the exact `cargo install` command in + `README.org` works (`--git` behaves a bit differently to `--path`) If the build fails after tagging: 1. fix the build From d510b7faf4eecad03347ad021614b673ae7a79a7 Mon Sep 17 00:00:00 2001 From: Marek Date: Tue, 19 Oct 2021 15:58:32 +0200 Subject: [PATCH 3/3] Fix a typo --- .github/PULL_REQUEST_TEMPLATE/release-checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md index 84a15a9fac0..8ebe8447b93 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md +++ b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md @@ -132,7 +132,7 @@ From "Keep a Changelog": ## Final Testing - [ ] After tagging the release, test that the exact `cargo install` command in - `README.org` works (`--git` behaves a bit differently to `--path`) + `README.md` works (`--git` behaves a bit differently to `--path`) If the build fails after tagging: 1. fix the build