Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Results scan service request to read any cached results for a set of keys #8205

Closed
arya2 opened this issue Jan 29, 2024 · 0 comments · Fixed by #8224
Closed

Implement Results scan service request to read any cached results for a set of keys #8205

arya2 opened this issue Jan 29, 2024 · 0 comments · Fixed by #8224
Assignees
@oxarbitrage
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-feature Category: New features S-needs-triage Status: A bug report needs triage
Milestone
RPC Interface for...

Comments

@arya2
Copy link
Contributor

arya2 commented Jan 29, 2024 •
edited
Loading

Motivation

We want to be able to request results for a given viewing key set from the scan service (to be used via an RPC method).

Possible Design

  • Accept a String in the ScanService Results request variant
  • Clone db and spawn a blocking thread
    • Call db.sapling_results(key) and return the transaction ids in the result
@arya2 arya2 mentioned this issue Jan 29, 2024
Closed
@github-project-automation github-project-automation bot moved this to New in Zebra Jan 29, 2024
@arya2 arya2 added C-feature Category: New features A-blockchain-scanner Area: Blockchain scanner of shielded transactions S-needs-triage Status: A bug report needs triage labels Jan 29, 2024
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Jan 29, 2024
@oxarbitrage oxarbitrage mentioned this issue Feb 1, 2024
Merged
7 tasks
@mergify mergify bot closed this as completed in #8224 Feb 2, 2024
@github-project-automation github-project-automation bot moved this from Sprint Backlog to Done in Zebra Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-feature Category: New features S-needs-triage Status: A bug report needs triage
Projects
Zebra
Status: Done
Milestone
RPC Interface for Zebra Blockchain Sc...
Development

Successfully merging a pull request may close this issue.

add(scan): Implement Results request ZcashFoundation/zebra
3 participants
@mpguerra @arya2 @oxarbitrage