-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(release): Enable all user features in the experimental
build
#7892
Comments
This is blocked by #7891 because we want the new features to appear in the new tags, after the breaking change. |
I've updated this ticket, it looks like we'll need an admin for parts of it, so let's check when @gustavovalverde is around. |
@gustavovalverde I'm unscheduling this one because there are more pressing things this sprint and I'm a bit lost with this one... Is there anything left to do here? |
The experimental build was added to CI in #8175 and is testing every PR update: https://github.com/ZcashFoundation/zebra/actions/runs/7997001572/job/21840879753#step:5:105 Some tests fail with the We may want an issue for fixing those test failures and adding it to the experimental build, or for adding the |
Going to close this as the original scope was done. We should open follow up issues if we want to add any new optional features, such as |
Motivation
We want to be able to point users to an experimental build for all new user features, not just one or two features we've been focused on recently. This makes using those features easier for users, because they don't have to build Zebra themselves.
It also makes our documentation simpler, because we can just say "use the
latest-experimental
image", rather than explaining which features are in it.Suggested Solution:
First PR:
experimental
feature tozebrad
that just activatesdefault-release-binaries
RUST_EXPERIMENTAL_FEATURES
GitHub Actions variable toexperimental
Second PR:
experimental
feature:elasticsearch
,journald
,prometheus
,filter-reload
,shielded-scan
experimental
feature (as well asgetblockchain-rpcs
andshielded-scan
), and add a config with all the experimental features enabledOptional
If the
Test all
job is slow:Not needed any more - job is fast
zebra/.github/workflows/ci-unit-tests-docker.yml
Lines 122 to 125 in afbe807
Specifications
No response
Complex Code or Requirements
We don't want to make CI fail when an admin changes the settings, so it's better to split this ticket into 2 PRs.
Testing
Make sure the tests are actually running in CI.
Related Work
No response
The text was updated successfully, but these errors were encountered: