-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failures in checkpoint generation log regex #7123
Comments
Does this one still need a fix? |
Yes, we need to relax the check in the test code so it accepts some range of blocks around the current height. Using a 1000 block range is too short and fails the test, but only rarely. A 10,000 block range would probably work fine, so would parsing the height and comparing it. There can't be too much of a gap between the current height and the start and end of the check range, otherwise the test will timeout and fail, skip too many checkpoints, or take too long. |
This happened again today in PR #7611: |
Just to be clear, I'm not working on this ticket, because we're trying to spread CI work around the team. |
Un-scheduling for now, doesn't seem to be high priority |
Just noting that this check will fail CI 40% of the time as soon as blocks get smaller, and we don't control block size. (That's based on the number of transactions.) |
Motivation
CI panicked in
wait_for_zebra_checkpoints_generation()
: https://github.com/ZcashFoundation/zebra/actions/runs/5418491535/jobs/9851372930?pr=7090#step:8:219Originally posted by @arya2 in #7090 (review)
Diagnosis
It looks like this regex might be too strict, Zebra logged a block height in the *9000 range before it was terminated.
The text was updated successfully, but these errors were encountered: