Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures in checkpoint generation log regex #7123

Closed
teor2345 opened this issue Jul 2, 2023 · 6 comments
Closed

Fix CI failures in checkpoint generation log regex #7123

teor2345 opened this issue Jul 2, 2023 · 6 comments
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures S-needs-triage Status: A bug report needs triage

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 2, 2023

Motivation

CI panicked in wait_for_zebra_checkpoints_generation(): https://github.com/ZcashFoundation/zebra/actions/runs/5418491535/jobs/9851372930?pr=7090#step:8:219

Originally posted by @arya2 in #7090 (review)

Diagnosis

It looks like this regex might be too strict, Zebra logged a block height in the *9000 range before it was terminated.

@mpguerra mpguerra added this to Zebra Jul 2, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Jul 2, 2023
@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage S-needs-investigation Status: Needs further investigation I-integration-fail Continuous integration fails, including build and test failures A-concurrency Area: Async code, needs extra work to make it work properly. and removed S-needs-investigation Status: Needs further investigation labels Jul 2, 2023
@mpguerra
Copy link
Contributor

Does this one still need a fix?

@teor2345
Copy link
Contributor Author

Yes, we need to relax the check in the test code so it accepts some range of blocks around the current height. Using a 1000 block range is too short and fails the test, but only rarely.

A 10,000 block range would probably work fine, so would parsing the height and comparing it. There can't be too much of a gap between the current height and the start and end of the check range, otherwise the test will timeout and fail, skip too many checkpoints, or take too long.

@teor2345
Copy link
Contributor Author

teor2345 commented Sep 25, 2023

@teor2345
Copy link
Contributor Author

Just to be clear, I'm not working on this ticket, because we're trying to spread CI work around the team.

@mpguerra
Copy link
Contributor

mpguerra commented Oct 5, 2023

Un-scheduling for now, doesn't seem to be high priority

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 5, 2023

Just noting that this check will fail CI 40% of the time as soon as blocks get smaller, and we don't control block size. (That's based on the number of transactions.)

@teor2345 teor2345 mentioned this issue Dec 7, 2023
44 tasks
@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Zebra Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures S-needs-triage Status: A bug report needs triage
Projects
Archived in project
Development

No branches or pull requests

2 participants