Add Zebra crate versions to dev-dependencies, to enable crater tests

[teor2345]

Motivation

If we add versions to all of Zebra's dev-dependencies, our crates will get tested by Rust compiler team crater runs.

This helps prevent build and test failures caused by future Rust compiler versions.

Specifications

https://rustc-dev-guide.rust-lang.org/tests/crater.html

Also possibly the restrictions here, if they are still current:
https://www.reddit.com/r/rust/comments/f5xpib/psa_denywarnings_is_actively_harmful/

And we might need optional feature dependencies:

feature_name = ["optional_dep?/feature_if_dep_activated_by_another_feature"]

Changes

• Add crate versions to all dev-dependencies on Zebra crates
  • Remove the tower-batch-control -> zebra-consensus circular dependency by copying those verifiers into tower-batch-control (and copying the tests into zebra-consensus so we're also testing the latest verifier code)
• Make sure the tests that are on by default:
  • run reasonably fast
  • don't use too much network
  • (check crater docs for any other requirements)

Testing

This needs testing using cargo release, to make sure there aren't any other circular dependencies.

Related Work

Split off PR #6908 and ticket #6149.

[mpguerra]

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn

[bishopcheckmate]

Hey, I would like to take on that.
I started checking and I think we could at this point just specify version = "1" for most relevant crates in dev-dependencies. Can you see any downside of this approach? I think it would a bit lower the maintenance burden

[arya2]

Hey, I would like to take on that. I started checking and I think we could at this point just specify version = "1" for most relevant crates in dev-dependencies. Can you see any downside of this approach? I think it would a bit lower the maintenance burden

Thank you!

It gave me a build error when I tried this, prerelease package needs to be specified explicitly, but I don't see any downside here if it works. The maintenance burden should be trivial if it needs to be a specific version.

[bishopcheckmate]

indeed it doesn't work for pre-release packages, tho it should work after 1.0.0. Anyway, I'll go with setting specific versions for now

[bishopcheckmate]

can you assign this to me please for easier searching?

[bishopcheckmate]

Also fyi since #8136 publishing will be blocked by zcash/librustzcash#1083 zcash/librustzcash#1088