Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zebra's peer set should drop multiple outbound connections to the same IP and port, Credit: Ziggurat Team #6805

Closed
teor2345 opened this issue May 31, 2023 · 0 comments · Fixed by #6832
Closed

Zebra's peer set should drop multiple outbound connections to the same IP and port, Credit: Ziggurat Team #6805

teor2345 opened this issue May 31, 2023 · 0 comments · Fixed by #6832
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-network Area: Network protocol updates or fixes C-bug Category: This is a bug C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network S-needs-triage Status: A bug report needs triage

Comments

@teor2345
Copy link
Contributor

Motivation

It looks like some Zebra instances are making multiple outbound connections to the same node:
https://forum.zcashcommunity.com/t/ziggurat-3-0/43350/40

This is a potential remote denial of service issue.

Complex Code or Requirements

This is concurrent code. The PeerSet should be dropping all but one outbound connection to the same IP address and port.

We should check that behaviour is actually happening, and that the connections are closed when they are dropped.

Testing

We have similar PeerSet tests with different IPs and ports, we should copy them and test with identical IPs and ports instead.

Related Work
@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-Low ❄️ C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network A-network Area: Network protocol updates or fixes A-concurrency Area: Async code, needs extra work to make it work properly. labels May 31, 2023
@mpguerra mpguerra added this to Zebra May 31, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra May 31, 2023
@teor2345 teor2345 mentioned this issue Jun 6, 2023
Merged
6 tasks
@teor2345 teor2345 changed the title Zebra's peer set should drop multiple outbound connections to the same IP and port Zebra's peer set should drop multiple outbound connections to the same IP and port, Credit: Ziggurat Team Jun 6, 2023
@teor2345 teor2345 changed the title Zebra's peer set should drop multiple outbound connections to the same IP and port, Credit: Ziggurat Team Zebra's peer set should drop multiple outbound connections to the same IP and port, Credit: Ziggurat Team Jun 6, 2023
@mergify mergify bot closed this as completed in #6832 Jun 7, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-network Area: Network protocol updates or fixes C-bug Category: This is a bug C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network S-needs-triage Status: A bug report needs triage
Projects
Zebra
Archived in project
Milestone
No milestone
1 participant
@teor2345