Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NCC-E005955-NQ6] zcash_proofs: Theoretical possibility of overflow leading to panic (Copy of zcash/librustzcash#786) #6327

Closed
mpguerra opened this issue Mar 15, 2023 · 3 comments
Assignees
Labels
C-audit Category: Issues arising from audit findings C-bug Category: This is a bug I-panic Zebra panics with an internal error message

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Mar 15, 2023

This issue mirrors zcash/librustzcash#786 in order to allow us to track it in Zenhub

@mpguerra mpguerra added this to Zebra Mar 15, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Mar 15, 2023
@mpguerra mpguerra added C-audit Category: Issues arising from audit findings P-Medium ⚡ labels Mar 15, 2023
@mpguerra mpguerra changed the title Copy of zcash/librustzcash#786 Copy of zcash/librustzcash#786(zcash_proofs: Theoretical possibility of overflow leading to panic) Mar 15, 2023
@mpguerra mpguerra changed the title Copy of zcash/librustzcash#786(zcash_proofs: Theoretical possibility of overflow leading to panic) zcash_proofs: Theoretical possibility of overflow leading to panic (Copy of zcash/librustzcash#786) Mar 15, 2023
@mpguerra mpguerra changed the title zcash_proofs: Theoretical possibility of overflow leading to panic (Copy of zcash/librustzcash#786) zcash_proofs: Theoretical possibility of overflow leading to panic (Copy of zcash/librustzcash#786) Mar 15, 2023
@mpguerra mpguerra changed the title zcash_proofs: Theoretical possibility of overflow leading to panic (Copy of zcash/librustzcash#786) [NCC-E005955-NQ6] zcash_proofs: Theoretical possibility of overflow leading to panic (Copy of zcash/librustzcash#786) Mar 16, 2023
@mpguerra
Copy link
Contributor Author

@upbqdn upbqdn self-assigned this Mar 21, 2023
@teor2345 teor2345 added C-bug Category: This is a bug I-panic Zebra panics with an internal error message labels Mar 22, 2023
@teor2345
Copy link
Contributor

This seems like a low priority because it can't happen with the current parameter sizes, and we don't plan on adding new downloadable parameters ever again.

@mpguerra
Copy link
Contributor Author

Done in zcash/librustzcash#805

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-audit Category: Issues arising from audit findings C-bug Category: This is a bug I-panic Zebra panics with an internal error message
Projects
Archived in project
Development

No branches or pull requests

3 participants