Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): define configuration variables for multiple workflows #6312

Closed
gustavovalverde opened this issue Mar 13, 2023 · 0 comments · Fixed by #6357
Closed

refactor(ci): define configuration variables for multiple workflows #6312

gustavovalverde opened this issue Mar 13, 2023 · 0 comments · Fixed by #6357
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-design Category: Software design work C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use

Comments

@gustavovalverde
Copy link
Member

Motivation

We stopped using secrets for non-sensitive information that could vary in some point in time, as there were some limitations with secrets while using reusable workflows, but GitHub recently added configuration variables to be used in multiple workflows, so we don't have to repeat ourselves: https://github.blog/2023-01-10-introducing-required-workflows-and-configuration-variables-to-github-actions/

Specifications

Documentation: https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows

Complex Code or Requirements

Some of the code/variables that needs to be added or changed:

  • Our GCP Project name
  • Our registry URLs
  • GCP machine types
  • Other variables that have an impact on all or most workflows

Testing

We must confirm a PR run all test successfully after the change

Related Work

ZcashFoundation/infra#8

@gustavovalverde gustavovalverde added C-design Category: Software design work A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-High 🔥 I-usability Zebra is hard to understand or use labels Mar 13, 2023
@mpguerra mpguerra added this to Zebra Mar 13, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Mar 13, 2023
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Mar 16, 2023
@mergify mergify bot closed this as completed in #6357 Apr 13, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-design Category: Software design work C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants