Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify z_listunifiedreceivers RPC implementation #6190

Closed
Tracked by #7366
oxarbitrage opened this issue Feb 20, 2023 · 3 comments
Closed
Tracked by #7366

Simplify z_listunifiedreceivers RPC implementation #6190

oxarbitrage opened this issue Feb 20, 2023 · 3 comments
Labels
A-rpc Area: Remote Procedure Call interfaces C-cleanup Category: This is a cleanup E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@oxarbitrage
Copy link
Contributor

After #6185 the z_listunifiedreceivers rpc method can be simplified by the use of try_from_unified function that properly parses UAs into individual addresses, and checks their validity as well.
@mpguerra mpguerra added this to Zebra Feb 20, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Feb 20, 2023
@oxarbitrage oxarbitrage added P-Low ❄️ A-rpc Area: Remote Procedure Call interfaces labels Feb 20, 2023
@teor2345
Copy link
Contributor

Here are some other optional changes we could make after PR #6185 merges:

@teor2345
Copy link
Contributor

Also we might want to update is_transparent and is_script_hash

@teor2345
Copy link
Contributor

teor2345 commented Feb 20, 2023 •
edited
Loading

Here are some follow-ups from z_validateaddress:
#6185 (review)

The future compatibility bug has a separate ticket #6193.

@teor2345 teor2345 added the C-cleanup Category: This is a cleanup label Feb 22, 2023
@teor2345 teor2345 changed the title Simplify z_listunifiedreceivers Simplify z_listunifiedreceivers implementation Apr 4, 2023
@teor2345 teor2345 changed the title Simplify z_listunifiedreceivers implementation Simplify z_listunifiedreceivers RPC implementation Apr 4, 2023
@mpguerra mpguerra mentioned this issue Aug 22, 2023
Closed
17 tasks
@teor2345 teor2345 added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jan 1, 2024
@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Zebra Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Area: Remote Procedure Call interfaces C-cleanup Category: This is a cleanup E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
Zebra
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpguerra @teor2345 @oxarbitrage