Require NU5 checkpoints regardless of zebrad.toml settings #6178
Labels
A-consensus
Area: Consensus rule updates
C-bug
Category: This is a bug
I-invalid-data
Zebra relies on invalid or untrusted data, or sends invalid data
I-lose-funds
Zebra loses user funds
S-needs-triage
Status: A bug report needs triage
Motivation
Mainnet nodes must check that their chain contains NU5 before:
lightwalletd
Ticket #5912 fixes this issue for the default config, so this is a low priority. It only affects configs generated before March 2022, or manually edited configs.
Specifications
https://zips.z.cash/protocol/protocol.pdf#blockchain
Complex Code or Requirements
We already have a mandatory checkpoint height, we just need to increase it.
We could also just ignore the
checkpoint_sync
setting, but that is more complicated, and it would make our CI images larger. (And maybe make the tests take longer.)Testing
This has an existing CI test, we'll need to make the regenerate-stateful-disks job into a long test:
zebra/.github/workflows/continous-integration-docker.yml
Line 353 in e78c5c5
zebra/.github/workflows/deploy-gcp-tests.yml
Lines 30 to 34 in e78c5c5
And then run it manually using "run workflow" on the branch for this ticket: https://github.com/ZcashFoundation/zebra/actions/workflows/continous-integration-docker.yml
Related Work
Follow up to:
The text was updated successfully, but these errors were encountered: