-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate BlockTemplate
fields using a new state request
#5455
Comments
@oxarbitrage I think the fields we need here are: New state request based on recent best blocks:
Standard library time function:
Can I edit the ticket, or did you want to? |
Please feel free to edit any of the getblocktemplate tickets. I did some some work already in the first one but none in the rest of them. |
BlockTemplate
fields with functional valuesBlockTemplate
fields using a new state request
Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn |
BlockTemplate
fields using a new state requestBlockTemplate
fields using a new state request
PR #5659 populates all of these fields except @mpguerra @oxarbitrage did you want to split that out into a separate ticket? |
I think @oxarbitrage is working on them in a separate PR so I think it's ok to just keep it in this ticket. |
Motivation
Whatever is not fixed values(#5452), coinbase transaction(#5453) or mempool transaction(#5454) will be state or Rust API values.
Tasks
Return state values in the
getblocktemplate
RPC method response:previousblockhash
height
defaultroots
chainhistoryroot
target
(same asbits
, but in a different format)mintime
These values should come from a new state request based on recent best blocks. We want to use a single state request for performance.
Return local node clock value in the
getblocktemplate
RPC method response:curtime
- using the same standard library time function as thetime
field consensus rule checkRelated Tickets
Depend on #5451
Can depend on #5452 for identification
The text was updated successfully, but these errors were encountered: