Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor QueuedBlocks and SentHashes fields on StateService to avoid unnecessary utxo removals and re-additions #5385

Closed
arya2 opened this issue Oct 11, 2022 · 1 comment
Labels
C-enhancement Category: This is an improvement

Comments

@arya2
Copy link
Contributor

arya2 commented Oct 11, 2022

Motivation

In PR #5257 known_utxos of queued blocks were added to the sent hashes when blocks are dequeued and sent to the block write task. Removing the UTXOs from QueuedBlocks and re-adding them to SentHashes can be easily avoided by coupling QueuedBlocks and SentHashes together.

See #5339

@arya2 arya2 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Oct 11, 2022
@teor2345
Copy link
Contributor

Thanks for opening this ticket!

I'm going to mark it as "not scheduled", because we're not doing changes this large while the audit is pending.

Feel free to re-open it if it's needed for other work, or after the audit fixes are complete.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

3 participants