Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the frequency of Zebra performance logs #4932

Closed
Tracked by #3096
teor2345 opened this issue Aug 23, 2022 · 1 comment
Closed
Tracked by #3096

Reduce the frequency of Zebra performance logs #4932

teor2345 opened this issue Aug 23, 2022 · 1 comment
Assignees
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug I-usability Zebra is hard to understand or use

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 23, 2022

Motivation

As part of #4747, we added some info-level performance logs to Zebra.

But performance is good enough now, so we can reduce the frequency of those logs.

Tasks

We could downgrade all the logs to debug level, but it might still be useful to log them for very long tasks.

For example:

  • the state can take up to a minute to commit a block, so we want to log that at trace or debug level
  • rebuilding non-finalized note commitment trees can take 1-2 minutes, so we could log that at info level
  • blocks timeout after 10 minutes, so we might want to log a warning before 10 minutes

The performance logging is implemented in:
https://github.com/ZcashFoundation/zebra/blob/main/zebra-chain/src/diagnostic.rs

@teor2345 teor2345 added C-bug Category: This is a bug P-Medium ⚡ I-usability Zebra is hard to understand or use A-diagnostics Area: Diagnosing issues or monitoring performance labels Aug 23, 2022
@teor2345 teor2345 changed the title Downgrade performance logging to debug level Reduce the frequence of Zebra performance logs Aug 23, 2022
@teor2345 teor2345 changed the title Reduce the frequence of Zebra performance logs Reduce the frequency of Zebra performance logs Aug 23, 2022
@teor2345 teor2345 assigned teor2345 and unassigned arya2 Aug 25, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Sep 2, 2022

Fixed by #4997.

@teor2345 teor2345 closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug I-usability Zebra is hard to understand or use
Projects
None yet
Development

No branches or pull requests

2 participants