Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of transactions sent in the lightwalletd send transaction test #4847

Closed
teor2345 opened this issue Jul 31, 2022 · 0 comments · Fixed by #4848
Closed

Limit the number of transactions sent in the lightwalletd send transaction test #4847

teor2345 opened this issue Jul 31, 2022 · 0 comments · Fixed by #4848
Assignees
@teor2345 @oxarbitrage
Labels
A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd

Comments

@teor2345
Copy link
Contributor

Motivation

We need to limit the number of transactions in the send transaction test, so it is less than the queue limit:

The application panicked (crashed).
Message: assertion failed: (left == right)
left: SendResponse { error_code: 0, error_message: "transaction dropped because the queue is full" },
right: SendResponse { error_code: 0, error_message: "\"c900ca01bee9a4b1e4868a9e1b208d7b8cbc470436e3d5b164b4f22b5a0c5e9d\"" }
Location: zebrad/tests/common/lightwalletd/send_transaction_test.rs:123

https://github.com/ZcashFoundation/zebra/runs/7587005032?check_suite_focus=true#step:6:193
@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels Jul 31, 2022
@teor2345 teor2345 changed the title Limit number of transactions sent in send transaction test Limit the number of transactions sent in the send transaction test Jul 31, 2022
@teor2345 teor2345 changed the title Limit the number of transactions sent in the send transaction test Limit the number of transactions sent in the lightwalletd send transaction test Jul 31, 2022
@teor2345 teor2345 self-assigned this Jul 31, 2022
@oxarbitrage oxarbitrage mentioned this issue Jul 31, 2022
Merged
2 tasks
@mergify mergify bot closed this as completed in #4848 Aug 1, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

@oxarbitrage oxarbitrage

Labels
A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): truncate the number of transactions in send transaction test ZcashFoundation/zebra
3 participants
@teor2345 @oxarbitrage @ftm1000