Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move debug stop at height to the zebrad start main loop #3442

Closed
teor2345 opened this issue Jan 30, 2022 · 3 comments
Closed

Move debug stop at height to the zebrad start main loop #3442

teor2345 opened this issue Jan 30, 2022 · 3 comments
Assignees
@jvff
Labels
C-enhancement Category: This is an improvement C-testing Category: These are tests

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jan 30, 2022 •
edited
Loading

Motivation

Currently, the debug stop at height config is implemented in the state service. But this makes shutdown difficult.

It would be better if we checked the stop conditions as part of the start command run loop in zebrad.

Related Work

This change will be easier after we add a task that stops the full sync in:
@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-testing Category: These are tests labels Jan 30, 2022
@teor2345 teor2345 mentioned this issue Feb 7, 2022
Closed
@teor2345 teor2345 changed the title Move debug stop at height to the syncer Move debug stop at height to the zebrad start main loop Feb 7, 2022
@ftm1000
Copy link

ftm1000 commented Feb 8, 2022

Hey team! Please add your planning poker estimate with ZenHub @gustavovalverde @dconnolly @conradoplg @jvff @oxarbitrage @teor2345 @upbqdn

@teor2345 teor2345 mentioned this issue Feb 8, 2022
Closed
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 1, 2022

@jvff do you mind if I close this ticket?

The current code seems to work, and it's totally unrelated to the light wallet epic.

@jvff
Copy link
Contributor

jvff commented Mar 3, 2022

Yeah, I think we will probably not need this any time soon.

@teor2345 teor2345 closed this as completed Mar 3, 2022
@teor2345 teor2345 mentioned this issue Mar 9, 2022
Merged
3 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
@arya2 arya2 mentioned this issue Mar 31, 2023
Merged
6 tasks
@mpguerra mpguerra mentioned this issue Apr 11, 2023
Closed
4 tasks
@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvff jvff

Labels
C-enhancement Category: This is an improvement C-testing Category: These are tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mpguerra @jvff @teor2345 @ftm1000