Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizing blocks appears to be slow when checkpointing large blocks #3438

Closed
jvff opened this issue Jan 30, 2022 · 4 comments
Closed

Finalizing blocks appears to be slow when checkpointing large blocks #3438

jvff opened this issue Jan 30, 2022 · 4 comments
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness

Comments

@jvff
Copy link
Contributor

jvff commented Jan 30, 2022

Motivation

The block synchronizer sometimes restarts when it all of the fanned out extend tip requests time out. When that happens, it can take a few minutes (5-15 minutes) for new blocks to start being downloaded because the request to obtain the block locator from takes a while to be processed by the state service. This happens because the state is busy committing checkpointed finalized blocks.

It would be nice to see if this can be improved to improve the synchronization performance.

Related Work

PRs:

Tickets:

@jvff jvff added C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Low ❄️ I-slow Problems with performance or responsiveness labels Jan 30, 2022
@teor2345
Copy link
Contributor

teor2345 commented Jan 30, 2022

If the state is busy committing blocks, then we should speed up the state commit code.

(If the syncer pauses while this happens, this is correct behaviour, and it shows that our backpressure is actually working.)

@ftm1000
Copy link

ftm1000 commented Feb 21, 2022

@ftm1000
Copy link

ftm1000 commented Feb 21, 2022

Please add your planning poker estimate with ZenHub @teor2345

@teor2345
Copy link
Contributor

This isn't causing us any issues right now.

@ZcashFoundation ZcashFoundation locked and limited conversation to collaborators Feb 28, 2022
@gustavovalverde gustavovalverde converted this issue into discussion #3672 Feb 28, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness
Projects
None yet
Development

No branches or pull requests

3 participants