Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tracing dependencies off of git #33

Closed
hdevalence opened this issue Sep 26, 2019 · 3 comments · Fixed by #58
Closed

Move tracing dependencies off of git #33

hdevalence opened this issue Sep 26, 2019 · 3 comments · Fixed by #58

Comments

@hdevalence
Copy link
Contributor

The upstream changes we added for skip are now released: tokio-rs/tracing#359 (comment)

@hdevalence
Copy link
Contributor Author

Ah -- because we're using tracing-futures, and the tokio-alpha feature for tracing-futures was fixed in git upstream, we can't move entirely off of git dependencies. So for now I think it's better to continue using the git dependencies.

@hdevalence
Copy link
Contributor Author

Poll::NotReady

@hdevalence
Copy link
Contributor Author

This went up so moving off of git may now be possible: https://crates.io/crates/tracing-futures/0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant