Document types specified in 7.1 Transaction Encoding and Consensus as part of the consensus rules

[mpguerra]

For each consensus rule:

• check that the rule is implemented in Zebra
• make sure the latest version of the rule is quoted in the docs for the code that implements it
• make sure the code implements the latest version of the rule

Subtasks

• Document types specified in 7.1: Transaction Header #3420
• Document types specified in 7.1: Transparent #3421
• Document types specified in 7.1: Sapling #3422
• Document types specified in 7.1: Sprout #3423
• Document types specified in 7.1: Orchard #3424

Zcash transaction format

https://zips.z.cash/protocol/protocol.pdf#txnencoding

Up to transaction v4

Transaction v5

Implementation

See #3223

[mpguerra]

Not sure if we can do any easy documentation here or if it's all over the codebase...

[teor2345]

Not sure if we can do any easy documentation here or if it's all over the codebase...

The format specs should be documented where the types are serialized and deserialized.

[teor2345]

Here is the split I'd suggest, because it matches the structure of Zebra's code (and also the spec):

• transaction header
• transparent
• sapling
• sprout
• orchard

You can see this split in the v5 transaction format, it's indicated using double lines. v1-v4 should follow the same split, even though the field order is different. The leftover JoinSplit fields are sprout fields.

We should cover all relevant transaction versions as part of each sub-ticket. (The code is repeated but usually identical.)

@mpguerra can you assign people to the sub-tasks after you've split this task?

[oxarbitrage]

Closed by #3491, #3498, #3499, #3501 and #3507