Stop ignoring panics in the peer receiver and heartbeat tasks

[teor2345]

Motivation

Zebra currently ignores panics in the peer message receiver task, and in the peer heartbeat task.

This can cause security or usability issues, because it can hide bugs, and cause hangs.

Designs

Add the join handles for these tasks to the Client, and poll them for panics during Client::poll_ready

zebra/zebra-network/src/peer/handshake.rs

Lines 929 to 931 in 3ddb9f9

	tokio::spawn(
	server
	.run(peer_rx)

zebra/zebra-network/src/peer/handshake.rs

Lines 947 to 948 in 3ddb9f9

	let heartbeat_ts_collector = address_book_updater.clone();
	tokio::spawn(

Related Work

This might be the cause of peer set or Zebra hangs.

[mpguerra]

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn