Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate owo-colors dependency #2984

Closed
teor2345 opened this issue Oct 31, 2021 · 2 comments
Closed

Remove duplicate owo-colors dependency #2984

teor2345 opened this issue Oct 31, 2021 · 2 comments
Labels
A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 31, 2021 •
edited
Loading

Motivation

Zebra currently depends on 2 different versions of the owo-colors crate, via:

  • zebra-test
  • color-eyre

If we remove duplicate dependencies, Zebra will compile faster, and its binaries will be smaller.

Steps

  1. Check that the conflict still exists by removing the owo-colors exception from deny.toml, then running cargo deny check bans.

Downgrade owo-colors:

  1. Make zebra-test depend on owo-colors >= 1.3.0

We could upgrade color-eyre, but that's out of scope.
@teor2345 teor2345 added A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Low labels Oct 31, 2021
@teor2345 teor2345 added this to the 2021 Sprint 24 milestone Oct 31, 2021
@teor2345 teor2345 mentioned this issue Nov 1, 2021
Merged
3 tasks
@conradoplg
Copy link
Collaborator

Hey team! Please add your planning poker estimate with ZenHub @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Nov 5, 2021
@teor2345
Copy link
Contributor Author

Obsoleted by #3343.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@conradoplg @mpguerra @teor2345