Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MEMPOOL_SIZE and just rely on the ZIP-401 cost limit #2958

Closed
Tracked by #2867
teor2345 opened this issue Oct 26, 2021 · 0 comments · Fixed by #2962 or #2932
Closed
Tracked by #2867

Remove MEMPOOL_SIZE and just rely on the ZIP-401 cost limit #2958

teor2345 opened this issue Oct 26, 2021 · 0 comments · Fixed by #2962 or #2932
Assignees
@conradoplg
Milestone
2021 Sprint 21

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 26, 2021 •
edited
Loading

Motivation

The current MEMPOOL_SIZE of 4 means that we'll never actually reach the ZIP-401 mempool cost limit.

Tasks

  • Remove MEMPOOL_SIZE
  • Quote the cost limit rule from ZIP-401 where it's actually used in the code
@teor2345 teor2345 mentioned this issue Oct 26, 2021
Closed
24 tasks
@teor2345 teor2345 changed the title Remove and just rely on the ZIP-401 cost limit Remove MEMPOOL_SIZE and just rely on the ZIP-401 cost limit Oct 26, 2021
@teor2345 teor2345 mentioned this issue Oct 26, 2021
Closed
@teor2345 teor2345 mentioned this issue Oct 26, 2021
Merged
3 tasks
@conradoplg conradoplg self-assigned this Oct 27, 2021
@conradoplg conradoplg mentioned this issue Oct 27, 2021
Merged
3 tasks
@dconnolly dconnolly added this to the 2021 Sprint 21 milestone Oct 27, 2021
@dconnolly dconnolly linked a pull request Oct 27, 2021 that will close this issue
Remove MEMPOOL_SIZE and just rely on the ZIP-401 cost limit #2962
Merged
3 tasks
@teor2345 teor2345 mentioned this issue Oct 27, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conradoplg conradoplg

Labels
None yet
Projects
None yet
Milestone
2021 Sprint 21
3 participants
@conradoplg @dconnolly @teor2345