Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade librustzcash-related crypto dependencies #2952

Closed
dconnolly opened this issue Oct 25, 2021 · 0 comments · Fixed by #3059
Closed

Upgrade librustzcash-related crypto dependencies #2952

dconnolly opened this issue Oct 25, 2021 · 0 comments · Fixed by #3059
Assignees
@dconnolly
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Milestone
2021 Sprint 22

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Oct 25, 2021 •
edited
Loading

Motivation

To remain compatible with our ECC dependencies and to be compliant with several consensus/spec rules, we should upgrade several of our
crypto dependencies before NU5 activation.

Details

  1. Merge these or more up to date closed PRs:

aes: #2703
bellman: #2837
bls12_381: #2731
fpe: 0.5.0
group: #2733
jubjub: #2730
redjubjub: 0.5.0 Tracked in #2549
x25519-dalek: #2762

  1. Remove the exceptions for these crates in deny.toml.

Related Work
@dconnolly dconnolly added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Oct 25, 2021
@dconnolly dconnolly added this to the 2021 Sprint 22 milestone Oct 25, 2021
@mpguerra mpguerra mentioned this issue Oct 26, 2021
Closed
This was referenced Oct 31, 2021
Closed
Merged
@teor2345 teor2345 mentioned this issue Nov 2, 2021
Closed
@dconnolly dconnolly mentioned this issue Nov 15, 2021
Merged
@upbqdn upbqdn mentioned this issue May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 22
Development

Successfully merging a pull request may close this issue.

Upgrade crypto deps ZcashFoundation/zebra
2 participants
@dconnolly @mpguerra