Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After NU5 mainnet activation, set the minimum mainnet network protocol version to NU5 #2813

Closed
teor2345 opened this issue Sep 30, 2021 · 1 comment
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks

Comments

@teor2345
Copy link
Contributor

Motivation

There might only be a small number of Zebra instances running when NU5 activates on mainnet.

So instead of automatically closing connections to outdated peers, we can just set the mainnet minimum protocol version to NU5 after NU5 mainnet activation.

Then we can upgrade and restart all the running Zebra instances, and they will reject outdated peers as soon as they start up, regardless of the synced block height.

Specifications

Original specification: ZIP 201: Network Peer Management for Overwinter

Since this is a network protocol specification, Zebra is free to adopt any compatible design.

Designs

Draft Zebra behaviour: ZIP 252: Deployment of the NU5 Network Upgrade - Support in Zebra

Related Work

This ticket is a smaller temporary substitute for #2262 and #2451.

If we make a similar minimum version change on mainnet, we don't need to implement #2451 at all.
But we still need to implement #2262 for the next network upgrade.

@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium A-network Area: Network protocol updates or fixes labels Sep 30, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Nov 8, 2021

This is a temporary substitute for #2262.

We should try to implement #2262 before NU5 mainnet activation, because we're going to have to do it eventually anyway.

@teor2345 teor2345 closed this as completed Nov 8, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

No branches or pull requests

2 participants