Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log level of mempool crawl errors #2655

Closed
Tracked by #2867
jvff opened this issue Aug 20, 2021 · 2 comments · Fixed by #3418
Closed
Tracked by #2867

Reduce log level of mempool crawl errors #2655

jvff opened this issue Aug 20, 2021 · 2 comments · Fixed by #3418
Assignees
@oxarbitrage
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use

Comments

@jvff
Copy link
Contributor

jvff commented Aug 20, 2021 •
edited by teor2345
Loading

Motivation

The mempool crawler currently logs all failures to request transaction IDs to peer using the info! level. However, the crawler should be robust enough to handle errors transparently, so the error logs don't necessarily add useful information. It's only useful while the mempool is under development. After the mempool becomes usable, the log level should be reduced to debug! or trace!.
@jvff jvff added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Aug 20, 2021
@jvff jvff mentioned this issue Aug 20, 2021
Merged
3 tasks
@mpguerra mpguerra added this to the 2021 Sprint 20 milestone Aug 26, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 20 milestone Sep 27, 2021
@teor2345 teor2345 mentioned this issue Oct 21, 2021
Closed
24 tasks
@mpguerra mpguerra added C-cleanup Category: This is a cleanup I-usability Zebra is hard to understand or use P-Medium labels Nov 23, 2021
@mpguerra mpguerra mentioned this issue Nov 23, 2021
Closed
76 tasks
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

@teor2345
Copy link
Contributor

Should there be an error! log if no transactions are received after some iterations?

No, it's totally ok for peers to rate-limit their mempool responses to us. And that's what zcashd seems to do.

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 10, 2021
@oxarbitrage oxarbitrage mentioned this issue Jan 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce log level of components oxarbitrage/zebra
4 participants
@mpguerra @jvff @teor2345 @oxarbitrage