-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fake_v5_transaction_with_orchard_actions_has_inputs_and_outputs
test
#2409
Comments
3 tasks
In the worst case this is a minor performance issue inside a specific test. Not very important at the moment. |
6 tasks
I accidentally addressed this by fixing something else. I'll open a PR soon. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #2398 we extended the
fake_v5_transaction_with_orchard_actions_has_inputs_and_outputs
unit test for new consensus rules.In this test we are calling
insert_fake_orchard_shielded_data()
multiple times which i think it can be avoided.This is a very low priority clean up task.
The text was updated successfully, but these errors were encountered: