Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fake_v5_transaction_with_orchard_actions_has_inputs_and_outputs test #2409

Closed
oxarbitrage opened this issue Jun 28, 2021 · 2 comments · Fixed by #9098
Closed

Improve fake_v5_transaction_with_orchard_actions_has_inputs_and_outputs test #2409

oxarbitrage opened this issue Jun 28, 2021 · 2 comments · Fixed by #9098
Assignees

Comments

@oxarbitrage
Copy link
Contributor

In #2398 we extended the fake_v5_transaction_with_orchard_actions_has_inputs_and_outputs unit test for new consensus rules.

In this test we are calling insert_fake_orchard_shielded_data() multiple times which i think it can be avoided.

This is a very low priority clean up task.

@oxarbitrage
Copy link
Contributor Author

In the worst case this is a minor performance issue inside a specific test. Not very important at the moment.

@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
@upbqdn upbqdn self-assigned this Dec 20, 2024
@upbqdn
Copy link
Member

upbqdn commented Dec 20, 2024

I accidentally addressed this by fixing something else. I'll open a PR soon.

@upbqdn upbqdn reopened this Dec 20, 2024
@mpguerra mpguerra added this to Zebra Jan 13, 2025
@github-project-automation github-project-automation bot moved this to New in Zebra Jan 13, 2025
@mpguerra mpguerra moved this from New to Review/QA in Zebra Jan 13, 2025
@mergify mergify bot closed this as completed in #9098 Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants