-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Transparent and Sapling validation for transaction v5 #1981
Labels
A-consensus
Area: Consensus rule updates
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
NU-5
Network Upgrade: NU5 specific tasks
Milestone
Comments
teor2345
added
A-consensus
Area: Consensus rule updates
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
S-needs-triage
Status: A bug report needs triage
NU-5
Network Upgrade: NU5 specific tasks
P-Medium
labels
Apr 6, 2021
Merged
2 tasks
3 tasks
3 tasks
3 tasks
3 tasks
This was referenced Jun 17, 2021
4 tasks
This was referenced Jun 30, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-consensus
Area: Consensus rule updates
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
NU-5
Network Upgrade: NU5 specific tasks
Is your feature request related to a problem? Please describe.
In #1829 and #1980, we parse and check transparent and sapling in transaction v5. But we need to call those functions in the transaction verifier.
Describe the solution you'd like
add
Transaction::V5
totransaction::check
(#1980 + PRs, #2070):PrevOut
s" coinbase check, added a few days ago in zcash/zips@10710d9add
Transaction::V5
totransaction::Verifier
:Transaction.network_upgrade
matches the currently active network upgrade (Validate nConsensusBranchId #2100)Other transparent and sapling consensus rules:
Describe alternatives you've considered
These consensus rules are required for NU5.
Additional context
We also need to implement Orchard validation for transaction v5 (#2379)
The text was updated successfully, but these errors were encountered: