Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zebra should auto-discover its own external IP address #1893

Closed
1 of 4 tasks
Tracked by #2310
teor2345 opened this issue Mar 12, 2021 · 1 comment
Closed
1 of 4 tasks
Tracked by #2310

Zebra should auto-discover its own external IP address #1893

teor2345 opened this issue Mar 12, 2021 · 1 comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use

Comments

@teor2345
Copy link
Contributor

teor2345 commented Mar 12, 2021

Is your feature request related to a problem? Please describe.

In #1890, we allow users to manually configure an external IP address for Zebra. But we can also detect this address automatically.

Describe the solution you'd like

This ticket depends on #1890. It also uses the unsolicited address advertisements in #1892.

If an IPv4 or IPv6 external address is not configured:

  • advertise the internal bind address, if it is a public IP address
  • otherwise, track the IPv4 and IPv6 addresses sent by peers in Version.address_recv
  • advertise the most popular IPv4 and IPv6 addresses using unsolicited Addr messages (see Zebra should try harder to discover and distribute good peer addresses #1892)
  • regularly remove addresses from old handshakes, so that nodes which change addresses learn their new addresses more quickly
    • but always keep at least one IPv4 or IPv6 address
@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Medium I-usability Zebra is hard to understand or use labels Mar 12, 2021
@mpguerra mpguerra added P-Low and removed P-Medium S-needs-triage Status: A bug report needs triage labels Mar 15, 2021
@teor2345
Copy link
Contributor Author

We probably won't do this any time soon.

@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
@mpguerra mpguerra reopened this Apr 29, 2024
@mpguerra mpguerra added this to Zebra Apr 29, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Apr 29, 2024
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Apr 29, 2024
@mpguerra mpguerra moved this from Sprint Backlog to Product Backlog in Zebra May 16, 2024
@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@github-project-automation github-project-automation bot moved this from Product Backlog to Done in Zebra Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use
Projects
Archived in project
Development

No branches or pull requests

2 participants