You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
teor2345 opened this issue
Feb 23, 2021
· 1 comment
Assignees
Labels
A-rustArea: Updates to Rust codeC-bugCategory: This is a bugC-cleanupCategory: This is a cleanupI-hangA Zebra component stops responding to requestsI-slowProblems with performance or responsiveness
A-rustArea: Updates to Rust codeC-bugCategory: This is a bugC-cleanupCategory: This is a cleanupI-hangA Zebra component stops responding to requestsI-slowProblems with performance or responsiveness
Is your feature request related to a problem? Please describe.
tower-batch
is missing a semaphore fix that wakes waiting clones on close: tower-rs/tower#480Describe the solution you'd like
semaphore.rs
included in our pinned version oftower
, totower-batch/src/
: https://github.com/tower-rs/tower/blob/d4d1c67c6a0e4213a52abcc2b9df6cc58276ee39/tower/src/semaphore.rsSync
bound to the semaphore futuretower_batch::Buffer
: https://github.com/tower-rs/tower/pull/480/files#diff-35398bbf39b455b121231a971e231cfc669556eda1c98705f367aa774f3da86cnew_with_close
inpair
pair
innew
tower_batch::Worker
: https://github.com/tower-rs/tower/pull/480/files#diff-868107348117bb575baa89a1a3aae31fb03e020ed6d709fe45443c4d65aefcebpin_project(PinnedDrop)
onWorker
close
toWorker
close
to wake waiting tasks on errorPinnedDrop
Describe alternatives you've considered
Do nothing:
tower-buffer
users might hang.Additional context
This issue was discovered during the review in #1593. It was partly fixed by #1671.
The text was updated successfully, but these errors were encountered: