Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tower-batch to avoid hangs on drop #1805

Closed
10 tasks done
teor2345 opened this issue Feb 23, 2021 · 1 comment
Closed
10 tasks done

Update tower-batch to avoid hangs on drop #1805

teor2345 opened this issue Feb 23, 2021 · 1 comment
Assignees
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-cleanup Category: This is a cleanup I-hang A Zebra component stops responding to requests I-slow Problems with performance or responsiveness
Milestone

Comments

@teor2345
Copy link
Contributor

teor2345 commented Feb 23, 2021

Is your feature request related to a problem? Please describe.

tower-batch is missing a semaphore fix that wakes waiting clones on close: tower-rs/tower#480

Describe the solution you'd like

Describe alternatives you've considered

Do nothing: tower-buffer users might hang.

Additional context

This issue was discovered during the review in #1593. It was partly fixed by #1671.

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-High I-hang A Zebra component stops responding to requests I-slow Problems with performance or responsiveness labels Feb 23, 2021
@teor2345 teor2345 self-assigned this Feb 23, 2021
@teor2345 teor2345 added this to the 2021 Sprint 5 milestone Feb 23, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 25, 2021
@teor2345 teor2345 removed their assignment Mar 8, 2021
@yaahc yaahc self-assigned this Mar 8, 2021
@mpguerra
Copy link
Contributor

closed by #1908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-cleanup Category: This is a cleanup I-hang A Zebra component stops responding to requests I-slow Problems with performance or responsiveness
Projects
None yet
Development

No branches or pull requests

3 participants