Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable sync_large_checkpoints_testnet test #1791

Closed
1 of 2 tasks
oxarbitrage opened this issue Feb 19, 2021 · 2 comments · Fixed by #1877
Closed
1 of 2 tasks

Re-enable sync_large_checkpoints_testnet test #1791

oxarbitrage opened this issue Feb 19, 2021 · 2 comments · Fixed by #1877
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Feb 19, 2021 •
edited by teor2345
Loading

Motivation

In PRs #1789 and #1887 we removed the sync_large_checkpoints_testnet because the testnet is unreliable.

Solution

This ticket is to bring that test back after we:

  • deploy more testnet nodes
  • fix the DNS seeders to remove unreliable or down nodes

Alternatives

  • increase the testnet acceptance test timeouts
  • decrease the number of blocks we sync on testnet
  • just disable the test and leave it disabled
@oxarbitrage oxarbitrage added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage S-blocked Status: Blocked on other tasks I-integration-fail Continuous integration fails, including build and test failures and removed C-enhancement Category: This is an improvement labels Feb 19, 2021
@teor2345 teor2345 mentioned this issue Feb 22, 2021
Merged
6 tasks
@mpguerra mpguerra added P-Medium and removed S-needs-triage Status: A bug report needs triage labels Feb 26, 2021
@mpguerra mpguerra added this to the 2021 Sprint 5 milestone Mar 9, 2021
@teor2345 teor2345 mentioned this issue Mar 9, 2021
Merged
@teor2345 teor2345 reopened this Mar 12, 2021
@teor2345 teor2345 added A-rust Area: Updates to Rust code C-bug Category: This is a bug and removed S-blocked Status: Blocked on other tasks labels Mar 12, 2021
@teor2345
Copy link
Contributor

We disabled these tests again in #1887, it looks like the zcashd instances from #1222 aren't turning up in the DNS seeders.

(But they seem to be interacting with the network OK, so this might be a DNS seeder issue.)

@teor2345 teor2345 modified the milestones: 2021 Sprint 5, 2021 Sprint 6 Mar 12, 2021
This was referenced Mar 12, 2021
Closed
Closed
@mpguerra mpguerra removed this from the 2021 Sprint 6 milestone Mar 17, 2021
@teor2345 teor2345 mentioned this issue May 3, 2022
Merged
3 tasks
@gustavovalverde gustavovalverde self-assigned this May 3, 2022
@teor2345
Copy link
Contributor

teor2345 commented May 3, 2022

We've decided not to fix some blockers for this ticket, so we can't do this ticket either.

@teor2345 teor2345 closed this as completed May 3, 2022
@arya2 arya2 mentioned this issue Mar 31, 2023
Merged
6 tasks
@mpguerra mpguerra mentioned this issue Apr 11, 2023
Closed
4 tasks
@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Disable unreliable sync_large_checkpoints_testnet" ZcashFoundation/zebra
4 participants
@mpguerra @teor2345 @gustavovalverde @oxarbitrage