Adjust zebrad Buffer sizes, and document Buffer constraints #1685
Labels
A-docs
Area: Documentation
A-rust
Area: Updates to Rust code
C-cleanup
Category: This is a cleanup
C-security
Category: Security issues
I-heavy
Problems with excessive memory, disk, or CPU usage
I-invalid-data
Zebra relies on invalid or untrusted data, or sends invalid data
Is your feature request related to a problem? Please describe.
zebrad
uses a lot ofBuffer
ed services, but we haven't really checked that their bounds are high enough.The underlying issues are:
Buffer
orBatch
with a small bound, Zebra can hang.Buffer
s orBatch
es with small bounds can also limit concurrency, particularly if the underlying service does a lot of work in itscall
.Describe the solution you'd like
Buffer
bounds acrosszebrad
Document the
Buffer
constraints in:commands::start
components::sync::ChainSync
components::sync::Inbound
See #1593 for details - ideally we should point to an RFC here.
Describe alternatives you've considered
Do nothing: the code might hang if future changes break the
poll_ready/call
invariants.Additional context
This issue was discovered during the review in #1593. It is a routine cleanup.
The text was updated successfully, but these errors were encountered: