We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceExt::oneshot
tower_batch::tests::ed25519
This issue was obsoleted by the fixes to the underlying issue in tower::Buffer, see #1593 for details.
tower::Buffer
Is your feature request related to a problem? Please describe.
tower_batch::tests::ed25519 uses the ready_and().await?.call() pattern, but we prefer the ServiceExt::oneshot pattern.
ready_and().await?.call()
Describe the solution you'd like
We should see if we can use the ServiceExt::oneshot pattern, to prevent future poll_ready/call mismatches:
poll_ready/call
sign_and_verify
See #1593 for details.
Describe alternatives you've considered
Do nothing: the code might hang if future changes break the poll_ready/call invariants.
Additional context
This issue was discovered during the review in #1593. It is a routine cleanup.
The text was updated successfully, but these errors were encountered:
Sorry, something went wrong.
No branches or pull requests
This issue was obsoleted by the fixes to the underlying issue in
tower::Buffer
, see #1593 for details.Is your feature request related to a problem? Please describe.
tower_batch::tests::ed25519
uses theready_and().await?.call()
pattern, but we prefer theServiceExt::oneshot
pattern.Describe the solution you'd like
We should see if we can use the
ServiceExt::oneshot
pattern, to prevent futurepoll_ready/call
mismatches:sign_and_verify
poll_ready/call
invariantsSee #1593 for details.
Describe alternatives you've considered
Do nothing: the code might hang if future changes break the
poll_ready/call
invariants.Additional context
This issue was discovered during the review in #1593. It is a routine cleanup.
The text was updated successfully, but these errors were encountered: