Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using ServiceExt::oneshot in tower_batch::tests::ed25519 #1673

Closed
2 tasks
teor2345 opened this issue Feb 3, 2021 · 1 comment
Closed
2 tasks

Try using ServiceExt::oneshot in tower_batch::tests::ed25519 #1673

teor2345 opened this issue Feb 3, 2021 · 1 comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup

Comments

@teor2345
Copy link
Contributor

teor2345 commented Feb 3, 2021

This issue was obsoleted by the fixes to the underlying issue in tower::Buffer, see #1593 for details.

Is your feature request related to a problem? Please describe.

tower_batch::tests::ed25519 uses the ready_and().await?.call() pattern, but we prefer the ServiceExt::oneshot pattern.

Describe the solution you'd like

We should see if we can use the ServiceExt::oneshot pattern, to prevent future poll_ready/call mismatches:

  • sign_and_verify
  • Document the poll_ready/call invariants

See #1593 for details.

Describe alternatives you've considered

Do nothing: the code might hang if future changes break the poll_ready/call invariants.

Additional context

This issue was discovered during the review in #1593. It is a routine cleanup.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Medium labels Feb 3, 2021
@teor2345
Copy link
Contributor Author

This issue was obsoleted by the fixes to the underlying issue in tower::Buffer, see #1593 for details.

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Development

No branches or pull requests

2 participants