We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe.
tower-batch has a very similar implementation to tower::buffer: https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L97 https://docs.rs/tower/0.4.4/src/tower/buffer/service.rs.html#112
tower-batch
tower::buffer
Like tower::buffer:
Batch
call
Describe the solution you'd like
Document these risks, but be more detailed than tower::buffer: https://docs.rs/tower/0.4.4/tower/buffer/struct.Buffer.html#a-note-on-choosing-a-bound
We probably want to add the details at module level, then add a summary on new and poll_ready: https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/lib.rs https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L53 https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L87
new
poll_ready
Describe alternatives you've considered
Do nothing. Callers risk hangs in tower-buffer.
tower-buffer
Additional context
See #1593 for the overall Buffer hang issue, analysis, and design patterns.
Buffer
The text was updated successfully, but these errors were encountered:
This task has been revised based on the fixes to the underlying Buffer issue, see #1593 for details.
Sorry, something went wrong.
The current settings seem fine.
No branches or pull requests
Is your feature request related to a problem? Please describe.
tower-batch
has a very similar implementation totower::buffer
:https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L97
https://docs.rs/tower/0.4.4/src/tower/buffer/service.rs.html#112
Like
tower::buffer
:Batch
with a small bound, theBatch
can hang.Batch
es with small bounds can also limit concurrency, particularly if the underlying service does a lot of work in itscall
.Describe the solution you'd like
Document these risks, but be more detailed than
tower::buffer
:https://docs.rs/tower/0.4.4/tower/buffer/struct.Buffer.html#a-note-on-choosing-a-bound
We probably want to add the details at module level, then add a summary on
new
andpoll_ready
:https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/lib.rs
https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L53
https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L87
Describe alternatives you've considered
Do nothing. Callers risk hangs in
tower-buffer
.Additional context
See #1593 for the overall
Buffer
hang issue, analysis, and design patterns.The text was updated successfully, but these errors were encountered: