Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows state path log message and acceptance test #1654

Closed
1 of 3 tasks
oxarbitrage opened this issue Jan 28, 2021 · 1 comment
Closed
1 of 3 tasks

Fix windows state path log message and acceptance test #1654

oxarbitrage opened this issue Jan 28, 2021 · 1 comment
Labels
C-bug Category: This is a bug

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Jan 28, 2021

In #1535 we added a test for state directory conflict zcash_state_conflict. This test open 2 nodes, the first one runs normally where the second one panics by directory already in use.

In the first test we want to make sure the output contains the message of opening of the cache. In unix this line looks something like this:

Opened Zebra state cache at "/tmp/zebrad_tests.ZiiNhboNnxg1/state/state/v4/mainnet"

However in windows this will look like:

Opened Zebra state cache at "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\zebrad_tests.xlVzwX42HIFB\\state\\state\\v4\\mainnet"

The double backslash there is already indicating a problem in the printing of the message that should be fixed. Then, the regex in the the zcash_state_conflict should be changed to match windows.

Todo:

  • Fix log message for windows.
  • Remove the unix conditional from the zcash_state_conflict.
  • Change the regex in zcash_state_conflict to match windows case.

Related Tickets

#1649 Distinguish between string literals and regexes in the acceptance tests

@oxarbitrage oxarbitrage added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-Low labels Jan 28, 2021
@teor2345 teor2345 changed the title Fix windows path log message and test Fix windows state path log message and acceptance test Jan 29, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 18, 2021
@oxarbitrage
Copy link
Contributor Author

We temporally disabled windows support by removing it from the CI. We will not fix this anytime soon.

@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants