From 63389d564e63ec9f39aeb1d8a11f4e25a240d2d3 Mon Sep 17 00:00:00 2001 From: teor Date: Thu, 29 Apr 2021 15:33:00 +1000 Subject: [PATCH] Remove broken ci-success check Previously, Zebra made ci-success a required check for merges to main. And then we made ci-success depend on a bunch of other CI checks. But this doesn't work as expected, because if the dependent checks fail, ci-success is skipped, and the branch protection rules allow the branch to be merged to main. --- .github/workflows/ci.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3dc60cb7b96..f69c729ef4a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,18 +9,6 @@ on: jobs: - ci-success: - name: 🏁 - runs-on: ubuntu-latest - needs: - - test - - build - - build-chain-no-features - - clippy - - fmt - steps: - - run: exit 0 - test: name: Test (+${{ matrix.rust }}) on ${{ matrix.os }} # The large timeout is to accommodate Windows builds